Gauge start-time is optional #2389
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #2389 +/- ##
=======================================
- Coverage 79.4% 79.3% -0.1%
=======================================
Files 123 123
Lines 21485 21566 +81
=======================================
+ Hits 17064 17108 +44
- Misses 4421 4458 +37 ☔ View full report in Codecov by Sentry. |
cijothomas
approved these changes
Dec 9, 2024
Member
cijothomas
left a comment
cijothomas
left a comment
There was a problem hiding this comment.
breaking changes for exporter author can be called out in the combined
changelog entry
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2387
Changes
DataPoint<T>into two separate structs:SumDataPoint<T>andGaugeDataPoint<T>start_timeinGaugeDataPoint<T>optionalMerge requirement checklist
CHANGELOG.mdfiles updated for non-trivial, user-facing changes